Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: populate asset ids from dutch auction schedule / withdraw #4816

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

cronokirby
Copy link
Contributor

Describe your changes

This populates the transaction perspective using the asset ids present in an auction, which improves display of auctions in transactions.

See #4815.

One thing missing to close the issue is that we don't correlate in the reserve information, but I'm not sure of a straightforward small change to do that.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    view code only

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and further action is tracked in #4815.

@conorsch conorsch merged commit 93218d3 into main Aug 15, 2024
13 checks passed
@conorsch conorsch deleted the 4815-auction-view-gather-asset-ids branch August 15, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants